Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace var statements with const or let statements #337

Merged
merged 1 commit into from
Mar 6, 2023
Merged

refactor: replace var statements with const or let statements #337

merged 1 commit into from
Mar 6, 2023

Conversation

shogo-nakano-desu
Copy link
Contributor

Description

As title says, replace all var statements with const or let statements to gain benefits from block scope and function scope which are introduced in ES6.

@saihaj
Copy link
Member

saihaj commented Feb 13, 2023

thanks for the cleanup!

@saihaj saihaj merged commit d87332a into graphql:main Mar 6, 2023
@shogo-nakano-desu shogo-nakano-desu deleted the eliminating-var-statement branch July 11, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saihaj saihaj saihaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shogo-nakano-desu @saihaj